[tizen_app_control] Fix potential race issue - #1078
Conversation
Subscribe to `onAppControl` before calling `sendLaunchRequest()` to avoid a potential race where broadcast-stream events could be missed.
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
JSUYA
left a comment
JSUYA
left a comment
There was a problem hiding this comment.
Could you clarify the specific scenario in which this issue occurs? The existing logic does not appear to have this problem. If the AppControl event arrives before Dart subscribes, the native embedder stores it in queue_ and delivers it when AppControl.onAppControl.first later subscribes.
Thanks. I will close this pr. |
2 participants
Subscribe to
onAppControlbefore callingsendLaunchRequest()to avoid a potential race where broadcast-stream events could be missed.